fix(win32): don't open extra terminal#159
Merged
angeloashmore merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
Member
|
Perfect! Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: N/A
Description
This updates the CLI's browser launcher so Windows opens authentication URLs without spawning an extra terminal window. It does that by using
start "" "<url>", which avoids having the quoted URL interpreted as the window title.It also routes
loginthrough the sharedopenBrowser()helper so browser-opening behavior stays centralized and consistent anywhere the CLI launches the user's browser.Checklist
Preview
N/A
How to QA 1
prismic login.prismic login --no-browserand confirm the CLI prints the login URL instead of trying to open a browser.Note
Low Risk
Low risk: small change to how the CLI shells out to open URLs, primarily affecting Windows
startbehavior; could only impact browser-launching flows.Overview
Centralizes
prismic loginbrowser launching by switching it to the sharedopenBrowser()helper instead of an inlineexecimplementation.Updates
openBrowser()on Windows to usestart "" "<url>"so opening authentication URLs no longer spawns an extra terminal window and avoids the URL being treated as the window title.Reviewed by Cursor Bugbot for commit 05d179d. Bugbot is set up for automated code reviews on this repo. Configure here.
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩